fix(Value.SummaryList): spacing of help when wrapped in Form.InfoOverlay
#4667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
force-pushed
the
fix/value-summarylist-in-info-overlay
branch
from
e9b3add to
201f039
Compare
langz
changed the title
help when wrapped in Form.InfoOverlayhelp when wrapped in Form.InfoOverlay
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
ohh, it looks like we need to fix this (in another PR). A div inside a dt is not valid HTML. <dl>
<dt>
<div>Invalid Term</div> <!-- ❌ Not valid -->
</dt>
<dd>Definition</dd>
</dl>I will commit a selector change to make it more save anyways. |
tujoworker
approved these changes
Mar 5, 2025
tujoworker
pushed a commit
that referenced
this pull request
Mar 5, 2025
## [10.66.1](v10.66.0...v10.66.1) (2025-03-05) ### 🐛 Bug Fixes * **DatePicker:** clear internal date when passing null ([#4656](#4656)) ([3ba3b26](3ba3b26)) * **Field.Date:** add missing support for `skipPortal` ([#4666](#4666)) ([975f3ea](975f3ea)) * **Field.Upload:** improve styling of `help` button ([#4659](#4659)) ([8a10d7c](8a10d7c)) * **Field.Upload:** set `aria-required` and `required` props in input rather than div ([#4655](#4655)) ([7db1f04](7db1f04)) * **Forms:** always render Field.Composition with a `fieldset` ([#4661](#4661)) ([a3991a1](a3991a1)) * **Value.SummaryList:** spacing of `help` when wrapped in `Form.InfoOverlay` ([#4667](#4667)) ([b7a2702](b7a2702)), closes [/github.com//pull/4667/files#diff-281ca53e6a78ae24056e8fc94bf0274576aef89044ddcc613fb09b0844023e13R50](https://github.com/dnbexperience//github.com/dnbexperience/eufemia/pull/4667/files/issues/diff-281ca53e6a78ae24056e8fc94bf0274576aef89044ddcc613fb09b0844023e13R50)
|
🎉 This PR is included in version 10.66.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: https://dnb-it.slack.com/archives/CMXABCHEY/p1741186089782099?thread_ts=1740042283.488439&cid=CMXABCHEY
CSB of the issue: https://codesandbox.io/p/devbox/value-padding-forked-jsz5nm?workspaceId=ws_LbiDwJdEBdbwxH2AkyAyVE
Issue is happening because the existing styling does not work when it shows up a
divlike so:<div class="dnb-space dnb-height-animation dnb-forms-visibility dnb-height-animation--is-visible dnb-height-animation--is-in-dom dnb-height-animation--parallax" aria-hidden="false">VALUE CONTENT HERE</div>Screenshot from CSB:
I've added a "quickfix" for this now, but doesn't feel 100% correct, as I'm just adding a specific selector to apply the existing css with margin when there's a
divthere as well.I'm not sure why the
divis present when wrapped in aForm.InfoOverlay, the fix could perhaps be related to not applying thatdiv(if possible).